-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table | Docs | Component testing and documentation #1216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikemai2awesome approved 👍 with a few minor edits to the manual testing steps. I converted them to use strict Gherkin format, i.e. Given, When, Then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I don't see any issues.
Jira
http://vjira2:8080/browse/BDS-957
Summary
Created tests for the table component.
Details
table.js
in the tests folder now contains tests for all props.testing.md
now has detailed instructions on manual testing.How to test
Run the branch locally and read through the testing javascript and markdown.